Re: [PATCH 09/19] perf tools: Fix 32-bit cross build

[Jiri Olsa]

On Mon, Oct 21, 2013 at 08:53:04AM +0300, Adrian Hunter wrote:
> On 20/10/13 23:42, Jiri Olsa wrote:
> > On Fri, Oct 18, 2013 at 03:29:06PM +0300, Adrian Hunter wrote:
> >> Setting EXTRA_CFLAGS=-m32 did not work because CFLAGS
> >> was not passed around.
> > 
> > this breaks feature detection for me on x86_64,
> > I've got following errors misdetection with this patch:
> > 
> > ...                       libperl: [ OFF ]

how about this one?

> > ...                       on-exit: [ OFF ]
> > 
> > and the build fails as well:
> > 
> >   CC       builtin-stat.o
> > builtin-record.c:42:12: error: static declaration of âon_exitâ follows non-static declaration
> > In file included from util/util.h:51:0,
> >                  from builtin.h:4,
> >                  from builtin-record.c:8:
> > /usr/include/stdlib.h:536:12: note: previous declaration of âon_exitâ was here
> > make[1]: *** [builtin-record.o] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [all] Error 2
> 
> That is fixed in patch 11: perf tools: Fix test_on_exit for 32-bit build

hum, could we apply those patches in reverse order?
I think the notion is not to break build deliberatelly
for the bisection sake.

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/