Re: [PATCH 1/4] drivers/misc: add rawio framework driver

From: Greg Kroah-Hartman
Date: Tue Oct 22 2013 - 01:44:19 EST


On Mon, Oct 21, 2013 at 05:03:20PM -0700, Bin Gao wrote:
> Rawio provides a framework to read/write registers from a bus, including
> pci, i2c, I/O device(memory mapped), etc. based on debug fs.
> Rawio bus drivers implement the read/write operation on a specific bus
> on top of the rawio framework driver.
> They are designed to help device driver and kernel debugging on
> embedded systems.

Oh, one more technical thing, you totally fail to document the
user/kernel api you have just created. You are parsing userspace data
in ways that I really don't understand at all...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/