Re: [PATCH 13/19] perf tools: Fix libunwind build and feature detectionfor 32-bit build

[Adrian Hunter]

On 21/10/13 17:14, Arnaldo Carvalho de Melo wrote:
> Em Sun, Oct 20, 2013 at 10:43:46PM +0200, Jiri Olsa escreveu:
>> On Fri, Oct 18, 2013 at 03:29:10PM +0300, Adrian Hunter wrote:
>>> Use -lunwind-x86 instead of -lunwind-x86_64 for 32-bit build.
> 
>>> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> 
>> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> 
> Doesn't apply because it depends on a patch in this series that I made a
> question about, the "CFLAGS=-g ... one, but then can we avoid touching
> this feature_check_code line with feature specific stuff, i.e. can't we
> just touch LDFLAGS or CFLAGS?

Because LDFLAGS and CFLAGS are used for all tests, all tests would
fail if any feature libraries were not present.

Also because 'make' invokes 'make' via a shell, it is not possible
to export variables.

That just leaves the command line as far as I can see.

> 
> - Arnaldo
> 
> --- tools/perf/config/Makefile
> +++ tools/perf/config/Makefile
> @@ -94,7 +96,7 @@
>  
>  feature_check = $(eval $(feature_check_code))
>  define feature_check_code
> -  feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(CFLAGS)" LDFLAGS=$(LDFLAGS) -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0)
> +  feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(CFLAGS)" LDFLAGS=$(LDFLAGS) LIBUNWIND_LIBS="$(LIBUNWIND_LIBS)" -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0)
>  endef
>  
>  feature_set = $(eval $(feature_set_code))
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/