Re: [PATCH 1/2] leds: lp55xx: handle enable pin in driver

[Linus Walleij]

On Tue, Oct 22, 2013 at 3:01 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote:

> This patch moves the handling of the chip's enable pin from the board
> code into the driver. It also updates all board-code files using the
> driver to incorporate this change.
>
> This is needed for device tree support of the enable pin.
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>

Looks good to me.

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

BTW: should we disable the GPIO when remove()ing the module?
This is a topic of another patch but...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/