Re: userspace firmware load fails with current linux-next

[Ming Lei]

Hi,

On Wed, 23 Oct 2013 11:06:18 +0200
Lothar WaÃmann <LW@xxxxxxxxxxxxxxxxxxx> wrote:

> Hi,
> 
> with the current linux-next loading firmware from userspace fails
> because when writing to /sys/class/firmware/*/data the return code is
> always 0 (meaning to the userspace too that no data was written).
> Thus the userspace tool (mdev) keeps writing the same block of data
> over and over again.
> 
> A cursory check of the latest updates to /drivers/base/firmware* didn't
> reveal anything that could be the cause of this misbehaviour.
> 
> Interestingly when changing the .size member of the
> struct bin_attribute firmware_attr_data in drivers/base/firmware_class.c
> (which is now '0') to e.g. PAGE_SIZE firmware loading works again.

Thank you for the report and analysis.

> 
> Since .size was at '0' since the beginning of the .git universe there
> must have been a fundamental change in the guts of the kernel handling
> sysfs attribute files.

It may be introduced by Tejun's recent change.

> 
> Is this behavioural change intended?

I think no.

> Do all sysfs attributes that are created with zero size need to be
> changed?

I think no, since drivers have no idea of size of their firmwares. 

> Or is it an unintended side effect of some recent change?

Maybe yes, could you test below patch?

Tejun, looks we need to keep special attention on zero size of bin file
as before, could you comment at the patch?

--
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 5d818df..366ae8d 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -277,7 +277,7 @@ static ssize_t sysfs_write_file(struct file *file, const char __user *user_buf,
 	ssize_t len = min_t(size_t, count, PAGE_SIZE);
 	char *buf;
 
-	if (sysfs_is_bin(of->sd)) {
+	if (sysfs_is_bin(of->sd) && size) {
 		loff_t size = file_inode(file)->i_size;
 
 		if (size <= *ppos)



Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/