Re: [PATCHv4 1/3] Input: twl4030-pwrbutton - add device tree support

[Sebastian Reichel]

Hi Florian,

On Thu, Oct 24, 2013 at 09:47:33AM +0200, Florian Vaussard wrote:
> > +Required SoC Specific Properties:
> > +- compatible: should be one of the following
> > +   - "ti,twl4030-pwrbutton": For controllers compatible with twl4030
> > +- interrupt: should be one of the following
> > +   - <8>: For controllers compatible with twl4030
> 
> This is <8> for your particular case, but it will depend on your
> SoC, won't it?  Moreover, this property will be most likely
> inherited from the root twl node, so I do not see the need to
> document it here. See:
> 
> Documentation/devicetree/bindings/mfd/twl-familly.txt

No. This is an internal twl4030 interrupt. TWL4030 functions
itself as an interrupt controller.

> > +
> > +Example:
> > +	twl_pwrbutton: pwrbutton {
> > +		compatible = "ti,twl4030-pwrbutton";
> > +		interrupts = <8>;
> > +	};
> 
> You are missing the root twl node here, no?

So should I document it like this?

twl4030 {
    compatible = "ti,twl4030";

    pwrbutton {
        compatible = "ti,twl4030-pwrbutton";
        interrupts = <8>;
    };
};

> > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> > index b9a05fd..a3a0fe3 100644
> > --- a/drivers/input/misc/twl4030-pwrbutton.c
> > +++ b/drivers/input/misc/twl4030-pwrbutton.c
> 
> Missing #include <linux/of.h> ?

It's included indirectly, but I should probably add a direct
include. Thanks.

> Best regards,

Thanks for the comments. I will sent out an updated patchset later.

-- Sebastian

Attachment: signature.asc
Description: Digital signature