Re: [PATCH 05/11] direct-io: only inc/dec inode->i_dio_count forfile systems

From: Jens Axboe
Date: Thu Oct 24 2013 - 05:49:55 EST


On Thu, Oct 24 2013, Christoph Hellwig wrote:
> On Thu, Oct 24, 2013 at 10:46:00AM +0100, Jens Axboe wrote:
> > On Thu, Oct 24 2013, Jens Axboe wrote:
> > > We don't need truncate protection for block devices, so add a flag
> > > bypassing this cache line dirtying twice for every IO. This easily
> > > contributes to 5-10% of the CPU time on high IOPS O_DIRECT testing.
> >
> > There's a merge error in this patch, please find the correct one below.
>
> Btw, I think this patch should not go in with this series but rather via
> the VFS tree as it's not related to the blk-mq infrastructure at all.

That'd be fine with me, if Al could pick it up if he agrees with it.
Feel free to add an acked/review-by :-)

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/