Re: [PATCH 2/2] ARM64: perf: wire up perf_regs and unwind support

[Jean Pihet]

Hi Jiri, Will,

On 24 October 2013 16:50, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> On Fri, Oct 18, 2013 at 04:54:38PM +0200, Jean Pihet wrote:
>
> SNIP
>
>> +     return -EINVAL;
>> +}
>> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
>> index 75b93d7..15a69a5 100644
>> --- a/tools/perf/config/Makefile
>> +++ b/tools/perf/config/Makefile
>> @@ -29,11 +29,17 @@ ifeq ($(ARCH),x86_64)
>>    NO_PERF_REGS := 0
>>    LIBUNWIND_LIBS = -lunwind -lunwind-x86_64
>>  endif
>> +
>>  ifeq ($(ARCH),arm)
>>    NO_PERF_REGS := 0
>>    LIBUNWIND_LIBS = -lunwind -lunwind-arm
>>  endif
>
> I dont see above 'ifeq' in acme's or in tip tree, so hunk
> below fails to apply.. what tree was this based on?
I am using 3.12-rc4. Let me rebase on the latest mainline.

Will, what do you think? I will post a rebased version asap.

> otherwise the change looks good to me
Great, thanks for reviewing!

>
> jirka

Jean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/