Re: [PATCH 01/11] Export __smp_call_function_single()

[Jens Axboe]

On Fri, Oct 25 2013, Ingo Molnar wrote:
> 
> * Jens Axboe <axboe@xxxxxxxxx> wrote:
> 
> > The blk-mq core and the blk-mq null driver uses it.
> > 
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> > ---
> >  kernel/smp.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/smp.c b/kernel/smp.c
> > index 0564571..9de461e 100644
> > --- a/kernel/smp.c
> > +++ b/kernel/smp.c
> > @@ -340,6 +340,7 @@ void __smp_call_function_single(int cpu, struct call_single_data *csd,
> >  	}
> >  	put_cpu();
> >  }
> > +EXPORT_SYMBOL(__smp_call_function_single);
> 
> I agree with exporting it to in-kernel users, but I'd prefer a _GPL 
> export for newly exported symbols that are for in-kernel use.

Agree, it should be _GPL. I will update the patch. Can I add your
acked-by?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/