Re: [PATCH v3 3/4] perf,x86: add Intel RAPL PMU support

[Jiri Olsa]

On Wed, Oct 23, 2013 at 02:58:04PM +0200, Stephane Eranian wrote:

SNIP

> +
> +	perf_cpu_notifier(rapl_cpu_notifier);
> +
> +	ret = perf_pmu_register(&rapl_pmu_class, "power", -1);
> +	WARN_ON(ret);
> +	if (!ret) {
> +		pr_info("RAPL PMU detected, registration failed, RAPL PMU disabled\n");
> +		put_online_cpus();
> +		return -1;
> +	}

should above rather be:

        if (WARN_ON(ret)) {
                pr_info("RAPL PMU detected, registration failed, RAPL PMU disabled\n");

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/