Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes forrunning LED patterns

[Bryan Wu]

On Fri, Oct 25, 2013 at 9:38 AM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> On Tuesday 13 August 2013 23:04:14 Bryan Wu wrote:
>> On Thu, Aug 8, 2013 at 12:59 AM, Milo Kim <woogyom.kim@xxxxxxxxx> wrote:
>> > This patch-set resolves the application conflict by
>> > restoring sysfs files.
>> >
>> > For LP5521
>> >
>> >   engine1/2/3_mode
>> >   engine1/2/3_load
>> >
>> > For LP5523
>> >
>> >   engine1/2/3_mode
>> >   engine1/2/3_load
>> >   engine1/2/3_leds
>> >
>> > Those attributes are accessed when LED pattern is run by
>> > custom application. Those were removed when LED pattern
>> > interface was changed to generic firmware interface. Please
>> > refer to commits below.
>> >
>> >   git commit 9ce7cb170f97f83a78dc948bf7d25690f15e1328
>> >   (leds-lp5521: use generic firmware interface)
>> >
>> >   git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0
>> >   (leds-lp5523: use generic firmware interface)
>> >
>> > Necessary attributes are restored in this patch-set.
>> >
>> > (Other changes)
>> > New data structure is added for handling values from/to an
>> > application. Few code fixes for reducing writing I2C
>> > commands.
>> > Add LP55xx common macros for code refactoring.
>> > Documentation updates.
>> >
>> > You can also pull from the location below
>> > This branch is based on 'for-next' of linux-leds.
>> >
>> >   https://github.com/milokim/lp55xx.git
>> >   resolve-missing-sysfs
>>
>> Thanks, I've already merged the whole patchset in my -devel
>> branch [1].
>>
>> Pali, could you please help to test it on your hardware? Just
>> grab my -devel branch and build then run.
>>
>> Thanks,
>> -Bryan
>>
>
> Hi, I see that all your patches are part of 3.12-rc5 kernel.
>
> Now I tested this example led program:
>
>     # Clearing LED-state to be sure
>     echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode
>     echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode
>     echo 0 > /sys/class/leds/lp5523:r/brightness
>     echo 0 > /sys/class/leds/lp5523:g/brightness
>     echo 0 > /sys/class/leds/lp5523:b/brightness
>
>     # Setting yellow light pattern and running it
>     echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode
>     echo "000001100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds
>     echo "9d804000427f0d7f7f007f0042000000" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load
>     echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode
>     echo "000000000" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds
>     echo "9d800000" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load
>     echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode
>     echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode
>     echo 20 > /sys/class/leds/lp5523:r/led_current
>     echo 2 > /sys/class/leds/lp5523:g/led_current
>     echo 0 > /sys/class/leds/lp5523:b/led_current
>
> All sysfs entries exists and every echo returned 0.
>
> But led does not start blinking that yellow ligh pattern.
> So it not working on 3.12-rc5 kernel :-(
>


OK, great! Do you still remember which kernel version works on you system?
Milo, do you have time to take a look? I bet it's a regression somewhere.

Thanks,
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/