Re: [PATCH] DYNAMIC_DEBUG: use select DEBUG_FS instead of dependson

[Randy Dunlap]

On 10/27/13 01:01, Krzysztof Mazur wrote:
> On Sat, Oct 26, 2013 at 08:30:00PM -0700, Greg Kroah-Hartman wrote:
>> On Sat, Oct 26, 2013 at 10:58:13PM +0200, Krzysztof Mazur wrote:
>>> Depending on options that are configured later makes them hard
>>> to enable unless the user knows that he must go backwards.
>>
>> Really?  We've had this for well over 2 years, people are confused about
>> this?
>>
>> Where?
> 
> The v3.10 is ok - CONFIG_DYNAMIC_DEBUG is after CONFIG_DEBUG_FS.
> 
> Maybe it's just me, because on my config I have CONFIG_DEBUG_FS=y,
> and on the system I was testing usbatm I had CONFIG_DEBUG_FS=n.
> 
> BTW, on x86_64 to disable CONFIG_DEBUG_FS you need to disable
> CONFIG_AMD_IOMMU_STATS, which is enabled by default in the
> x86_64_defconfig (I think that CONFIG_AMD_IOMMU_STATS=n it's
> a better default). If you enable CONFIG_DEBUG_KERNEL you
> need to disable CONFIG_FTRACE which is enabled by default.
> So a lot of users will have CONFIG_DEBUG_FS already selected.

You are making a good argument for not using 'select' at all.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/