RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

[Venkat Venkatsubra]

-----Original Message-----
From: David Miller [mailto:davem@xxxxxxxxxxxxx] 
Sent: Sunday, October 27, 2013 11:27 PM
To: ben@xxxxxxxxxxxxxxx
Cc: Venkat Venkatsubra; linux-kernel@xxxxxxxxxxxxxxx; rds-devel@xxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
Date: Sun, 27 Oct 2013 21:54:16 +0000

> Most architectures define virt_to_page() as a macro that casts its 
> argument such that an argument of type unsigned long will be accepted 
> without complaint.  However, the proper type is void *, and passing 
> unsigned long results in a warning on MIPS.
> 
> Compile-tested only.
> 
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

This looks fine:

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/