Re: [PATCH v2 1/2] clk/zynq/clkc: Add 'fclk-enable' feature

[Kumar Gala]

On Oct 28, 2013, at 5:17 PM, Tomasz Figa wrote:

>>>> diff --git a/Documentation/devicetree/bindings/clock/zynq-7000.txt
>>>> b/Documentation/devicetree/bindings/clock/zynq-7000.txt index
>>>> d99af878f5d7..11fdd146ec83 100644
>>>> --- a/Documentation/devicetree/bindings/clock/zynq-7000.txt
>>>> +++ b/Documentation/devicetree/bindings/clock/zynq-7000.txt
>>>> 
>>>> @@ -22,6 +22,10 @@ Required properties:
>>>> Optional properties:
>>>>  - clocks : as described in the clock bindings
>>>>  - clock-names : as described in the clock bindings
>>>> 
>>>> + - fclk-enable : Bit mask to enable FCLKs in cases no proper CCF
>>> 
>>> Since it's a vendor specific property, it should include vendor
>>> prefix.
>> 
>> The whole driver is vendor specific. Should there really be another
>> prefix for that property?
> 
> Yes. If a property is introduced just for use by this particular driver 
> then it must be prepended by a vendor prefix. That's a general rule.

Most all nodes are vendor specific by definition ;).

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/