Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new linecharacter in the macro

[Chen Gang]

On 10/29/2013 06:39 PM, David Howells wrote:
> Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> 
>>> > > And you also need to fix kernel/modsign_certificate.S as part of same patchset as
>>> > > that is where the problem started in first place.
>>> > > 
>> > 
>> > Hmm... can that be another patch?
>> > 
>> > For "kernel/modsign_certificate.S", I recommend to expand the macro
>> > which will shrink code line, either need not include additional header
>> > file, I feel that will be simpler for both code reader and writers.
> I recommend leaving that file alone.  That gets moved to a .S file in patches
> queued in the security tree.

Excuse me, I am not quite familiar with our version merging, I guess
your meaning is "this file will be removed, and the related contents
will be in another .S file, so we need not fix it within this file".

If what I guess is correct, I support your recommendation (and if what I
guess is incorrect, please let me know, thanks). :-)

BTW: I still use next-20130927 tree for it, and another next-tree branch
which is next-20131025 do not have this file.


Thanks.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/