Re: [PATCH] scripts/kconfig/menu.c: warning: jump may be useduninitialized in this function

[Yann E. MORIN]

Christian, All,

On 2013-10-27 19:02 -0700, Christian Kujau spake thusly:
> On Sun, 27 Oct 2013 at 18:28, Christian Kujau wrote:
> > While doing "make oldconfig" on 3.12-rc7 with gcc-4.7.2 (Debian), the 
> > following warning is printed:
> > 
> >   HOSTCC  scripts/kconfig/zconf.tab.o
> > In file included from scripts/kconfig/zconf.tab.c:2537:0:
> > /usr/local/src/linux-git/scripts/kconfig/menu.c: In function âget_symbol_strâ:
> > /usr/local/src/linux-git/scripts/kconfig/menu.c:586:18: warning: âjumpâ may be used uninitialized in this function [-Wmaybe-uninitialized]
> > /usr/local/src/linux-git/scripts/kconfig/menu.c:547:19: note: âjumpâ was declared here
> 
> Grrr, only after I sent this message I found this was reported in 
> September already by Madhavan Srinivasan:  https://lkml.org/lkml/2013/9/19/24
> 
> Does anybody know the state of this fix?

The solution was to properly comment that this was a gcc issue, in that 
this is a spurious error, does not appear in previous gcc versions, and
has been fixed in later gcc versions.

Setting 'jump' to NULL may hide reall issues in case the code is changed
in the future, so it is not appropriate a fix. Hence why the previously-
submitted patches were not applied.

I'll take this on me to properly fix this. Thanks for the heads up.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/