Re: [PATCH 2/5] fat: add fat_fallocate operation

[Namjae Jeon]

2013/10/30, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> Namjae Jeon <linkinjeon@xxxxxxxxx> writes:
>
>>>> +	/* Release unwritten fallocated blocks on file release. */
>>>> +	if (round_up(inode->i_size, sb->s_blocksize) <
>>>> +	    MSDOS_I(inode)->i_disksize && inode->i_nlink != 0)
>>>> +		fat_truncate_blocks(inode, inode->i_size);
>>>> +
>>>>  	truncate_inode_pages(&inode->i_data, 0);
>>>>  	if (!inode->i_nlink) {
>>>>  		inode->i_size = 0;
>
> [...]
>
>>> And inode->i_size should be ->mmu_private?
>> Sorry, I don't understand your question yet...
>> Could you elaborate more ?
>
> "if" part is checking "round_up(->i_size) < ->i_disksize", but I guess
> fallocate() truncation should be only needed if there is uninitialized
> data. So, I felt that part should check ->mmu_private and ->i_disksize.
Yes, right. I will change it as your points.
Thanks for review!!

>
> Thanks.
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/