Re: [PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL()
From: David Howells
Date: Wed Oct 30 2013 - 08:58:25 EST
Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> If a macro is only used within 2 times, and also its contents are
> within 2 lines, recommend to expand it to shrink code line.
>
> For our case, the macro is not portable either: some architectures'
> assembler may use another character to mark newline in a macro (e.g.
> '`' for arc), which will cause issue.
>
> If still want to use macro and let it portable enough, it will also
> need include additional header file (e.g "#include <linux/linkage.h>",
> although it also need be fixed).
Fine by me.
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/