Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3)

[Greg KH]

On Wed, Oct 30, 2013 at 12:19:58PM +0100, Frank Haverkamp wrote:
> Hi Greg,
> 
> Am Freitag, den 25.10.2013, 16:21 +0100 schrieb Greg KH:
> > On Fri, Oct 25, 2013 at 04:00:44PM +0200, Frank Haverkamp wrote:
> > > > And why are you doing debug stuff through the ioctl interface?  Please
> > > > move that to debugfs if you really want/need that information, it does
> > > > not belong in an ioctl.
> > > 
> > > I will look into that. We need that information per card when it fails.
> > 
> > People put per-card information in debugfs all the time, look at the USB
> > host controller files in debugfs for an example of how to do this.
> 
> Thanks for pointing me to the example. I moved some of my former sysfs
> interfaces to debugfs. Especially those which were printing out more
> than one item. I guess you don't like those in sysfs anyways.

It's forbidden, thanks for noticing and fixing that before I had to say
the same thing later...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/