Re: [RFC/PATCH v2 1/3] usb: gadget: add quirks field to struct usb_gadget

[David Cohen]

> > diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> > index 942ef5e..7014ad9 100644
> > --- a/include/linux/usb/gadget.h
> > +++ b/include/linux/usb/gadget.h
> > @@ -540,6 +540,11 @@ struct usb_gadget {
> >   	struct device			dev;
> >   	unsigned			out_epnum;
> >   	unsigned			in_epnum;
> > +
> > +	u32				quirks;
> > +/* epout requires buffer size to be aligned to MaxPacketSize */
> > +#define USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE		(1 << 0)
>
> If you decide to go through with this, it might be better to define a
> series of single-bit flags instead of a single "quirks" field.  For
> example:
>
> 	unsigned			quirk_ep_out_aligned_size:1;
>
> Yes, other people (including me!) have done it your way in the past,
> but now this seems to make more sense.

It would be less error-prone. I'll change it.

Thanks,

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/