Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support

From: Philippe Rétornaz
Date: Thu Oct 31 2013 - 03:54:21 EST


Hi


+ /* When using dual fifo mode, we need to keep watermark
+ * as even numbers due to dma script limitation.
+ */
+ ssi_private->dma_params_tx.maxburst /= 2;
+ ssi_private->dma_params_tx.maxburst *= 2;
+ ssi_private->dma_params_rx.maxburst /= 2;
+ ssi_private->dma_params_rx.maxburst *= 2;


Why not using a mask here ?
ssi_private->dma_params_tx.maxburst &= ~0x1;
ssi_private->dma_params_rx.maxburst &= ~0x1;

Regards,

Philippe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/