RE: [PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support forCrossbar IP

[R, Sricharan]

Hi Thomas,
  Again sorry for top post. 

  I agree and will fix both of the comments below.

  Thanks for the reviews.

Regards,
 Sricharan
________________________________________
From: Thomas Gleixner [tglx@xxxxxxxxxxxxx]
Sent: Wednesday, October 30, 2013 9:00 PM
To: R, Sricharan
Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; linus.walleij@xxxxxxxxxx; linux@xxxxxxxxxxxxxxxx; tony@xxxxxxxxxxx; Nayak, Rajendra; marc.zyngier@xxxxxxx; grant.likely@xxxxxxxxxx; mark.rutland@xxxxxxx; robherring2@xxxxxxxxx; Shilimkar, Santosh; Rob Herring
Subject: Re: [PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

On Wed, 30 Oct 2013, Sricharan R wrote:
> +static inline const u32 allocate_free_irq(int cb_no)

I understand the "static inline" part, but "const u32" is more than
fishy. What's wrong with "static inline int" ?

> +{
> +     int i;
> +
> +     for (i = 0; i < cb->int_max; i++) {
> +             if (cb->irq_map[i] == IRQ_FREE) {
> +                     cb->irq_map[i] = cb_no;
> +                     return i;
> +             }
> +     }
> +
> +     return -ENODEV;
> +}

> +static int crossbar_domain_xlate(struct irq_domain *d,
> +                              struct device_node *controller,
> +                              const u32 *intspec, unsigned int intsize,
> +                              unsigned long *out_hwirq,
> +                              unsigned int *out_type)
> +{
> +     unsigned long ret = 0;

Why do you need to initialize ret when you assign a value to it in the
next line?

Thanks,

        tglx--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/