Re: [PATCH] recordmcount.pl: add support for __fentry__

From: Jamie Iles
Date: Thu Oct 31 2013 - 12:18:46 EST


On Thu, Oct 31, 2013 at 12:09:26PM -0400, Steven Rostedt wrote:
> On Thu, 31 Oct 2013 15:59:58 +0000
> Jamie Iles <jamie.iles@xxxxxxxxxx> wrote:
>
> > With gcc 4.6.0 the -mfentry feature places the function profiling call
> > at the start of the function. When this is used, the call is to
> > __fentry__ and not mcount.
> >
> > Based on 48bb5dc6cd9d30fe0d594947563da1f8bd9abada (ftrace: Make
> > recordmcount.c handle __fentry__).
>
> Why? All current users of __fentry__ use the C version of recordmcount.
> This just slows down the few archs that still use recordmcount.pl.

Okay, it's probably fair to drop this one then if it's not useful to the
other arches. We have a corner case with Ksplice where the C version of
mcount not writing the section symbol for __mcount_loc causes a problem
and we fall back to the perl version, but I'll spend some time working
on fixing that instead.

Thanks,

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/