Re: [PATCH][RESEND] lib/genalloc: add a helper function for DMAbuffer allocation

[Nicolin Chen]

Sir,

On Thu, Oct 31, 2013 at 02:26:19PM -0700, Andrew Morton wrote:
> On Thu, 31 Oct 2013 17:16:07 +0800 Nicolin Chen <b42378@xxxxxxxxxxxxx> wrote:
> 
> > When using pool space for DMA buffer, there might be duplicated calling
> > of gen_pool_alloc() and gen_pool_virt_to_phys() in each implementation.
> > 
> > Thus it's better to add a simple helper function, a compatible one to
> > the common dma_alloc_coherent(), to save some code.
> > 
> 
> Well OK, but this new function doesn't have any callers.  So it
> increases kernel size and is untestable.
> 
> Do you have any conversion patches which we can merge to address these
> problems?
> 
>

I'll later send a patch to convert all the combinations of gen_pool_alloc()
and gen_pool_virt_to_phys(), within the entire kernel, to this helper func.

This would need quite a lot people engaged to test it.

If anything unexpected happens during the test, we can refine and fix it.
Surely, if some owners of modified driver don't want their code be altered,
I can drop those modification to their drivers.

Is this okay?

Thank you,
Nicolin Chen


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/