Re: [PATCH trace-cmd 1/5] trace-cmd/listen: Remove use ofsighandler_t

From: Steven Rostedt
Date: Fri Nov 01 2013 - 09:40:20 EST


On Mon, 28 Oct 2013 10:45:41 -0500
Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote:

>
> >From 20ec8510d0ca2ac789b1ca9cf7b0a6dc2d02f14c Mon Sep 17 00:00:00 2001
> From: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> Date: Mon, 28 Oct 2013 08:15:59 -0500
> Subject: [PATCH] Makefile: Ensure _GNU_SOURCE really is always defined
>
> When CLFAGS is set with a command argument a normal variable
> assignment is not sufficient to ensure that _GNU_SOURCE will be
> defined. Since this really is critical for building, use an
> override directive when adding it to CFLAGS to ensure that it
> really does get defined in all cases.

Can you send this as a separate patch please. New patches should not
be replies. You can reply to a patch with a patch, but please change
the subject when you do so.

Thanks,

-- Steve

>
> Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 1d613c4..a2ba385 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -223,7 +223,7 @@ CFLAGS ?= -g -Wall
> LDFLAGS ?=
>
> # Required CFLAGS
> -CFLAGS += -D_GNU_SOURCE
> +override CFLAGS += -D_GNU_SOURCE
>
> ifndef NO_PTRACE
> ifneq ($(call try-cc,$(SOURCE_PTRACE),),y)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/