Fwd: [PATCH v2] kernel/resource.c: use signed length comparing insteadof position comparing
From: Chen Gang
Date: Mon Nov 04 2013 - 01:06:42 EST
Sorry, forgot to cc linux-kernel.
-------- Original Message --------
Subject: [PATCH v2] kernel/resource.c: use signed length comparing instead of position comparing
Date: Mon, 04 Nov 2013 11:05:30 +0800
From: Chen Gang <gang.chen@xxxxxxxxxxx>
To: Toshi Kani <toshi.kani@xxxxxx>, "isimatu.yasuaki@xxxxxxxxxxxxxx" <isimatu.yasuaki@xxxxxxxxxxxxxx>, gong.chen@xxxxxxxxxxxxxxx, haokexin@xxxxxxxxx
CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Theoretically, "addr + size" may be overflow (e.g. equal 0), so use
signed length comparing instead of position comparing.
Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
---
kernel/resource.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index 3f285dc..0783733 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1335,7 +1335,7 @@ int iomem_is_exclusive(u64 addr)
* We can probably skip the resources without
* IORESOURCE_IO attribute?
*/
- if (p->start >= addr + size)
+ if ((s64)(p->start - addr) >= size)
break;
if (p->end < addr)
continue;
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/