Re: [PATCH 3/3] perf tools: Check maximum frequency rate forrecord/top

[Jiri Olsa]

On Mon, Nov 04, 2013 at 08:17:24AM -0700, David Ahern wrote:
> On 11/4/13, 4:06 AM, Jiri Olsa wrote:
> >Adding the check for maximum allowed frequency rate
> >defined in following file:
> >   /proc/sys/kernel/perf_event_max_sample_rate
> >
> >When we cross the maximum value we fail and display
> >detailed error message with advise.
> 
> perf commands should automatically adjust the default frequency too.
> If the user did not specify a frequency then this message is going
> to be confusing.

ok, I'll add that check and probably some warning
if we are force to go below the default rate.

> 
> Though the algorithm that keeps lowering the rate should be tweaked as well.

yea.. I was thinking putting the max rate back up after
some sane period

or/plus having 'echo 0 > /proc/sys/kernel/perf_event_max_sample_rate' to
disable it completely

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/