Re: [PATCH V2] xfs: simplify kmem_{zone_}zalloc
From: Dave Chinner
Date: Mon Nov 04 2013 - 16:00:19 EST
On Mon, Nov 04, 2013 at 06:21:05PM +0800, Gu Zheng wrote:
> Introduce flag KM_ZERO which is used to alloc zeroed entry, and convert
> kmem_{zone_}zalloc to call kmem_{zone_}alloc() with KM_ZERO directly,
> in order to avoid the setting to zero step.
> And following Dave's suggestion, make kmem_{zone_}zalloc static inline
> into kmem.h as they're now just a simple wrapper.
>
> V2:
> Make kmem_{zone_}zalloc static inline into kmem.h as Dave suggested.
>
> Signed-off-by: Gu Zheng <guz.fnst@xxxxxxxxxxxxxx>
Looks good. It also results in a slight reduction in code size:
text data bss dec hex filename
792234 99018 632 891884 d9bec fs/xfs/xfs.o.orig
792090 99018 632 891740 d9b5c fs/xfs/xfs.o
Which means making it inline hasn't cost us anything at individual
call sites.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/