Re: [PATCH] net: don't forget to free sk_filter

From: Daniel Borkmann
Date: Wed Nov 06 2013 - 14:32:22 EST


On 11/06/2013 08:28 PM, Eric Dumazet wrote:
On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote:

When you send v2 with Alexei's feedback, please also be more specific
in your subject like "net: x86: bpf: don't forget to free sk_filter"
or the like. Also it's enough to say 'This memory leak was introduced
by commit d45ed4a4e3 ("net: fix unsafe set_memory_rw from softirq")'
instead of copying the whole log. Anyways, for v2 with feedback included
then:

Actually, the new way [1] of doing this would be to use the 'Fixes:' tag
as in :

Fixes: <12 digits SHA1> ("net: fix unsafe set_memory_rw from softirq")

[1] As discussed at last Kernel Summit

Example in

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6920a1bd037374a632d585de127b6f945199dcb8

Cool, good to know, that's even better!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/