Re: [memcg:since-3.12 75/75] fs/proc/meminfo.c:undefined referenceto `vm_commit_limit'

[Michal Hocko]

On Thu 07-11-13 19:08:16, Wu Fengguang wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.12
> head:   2f11d7af8df66cb4f217b6293ad8189aa101d601
> commit: 2f11d7af8df66cb4f217b6293ad8189aa101d601 [75/75] mm-factor-commit-limit-calculation-fix
> config: make ARCH=blackfin BF526-EZBRD_defconfig
> 
> All error/warnings:
> 
>    mm/built-in.o: In function `__vm_enough_memory':
>    (.text+0x11b4c): undefined reference to `vm_commit_limit'
>    fs/built-in.o: In function `meminfo_proc_show':
> >> fs/proc/meminfo.c:(.text+0x37ef0): undefined reference to `vm_commit_limit'

Andrew, it seems that moving vm_commit_limit out of mman.h is not that
easy because it breaks NOMMU configurations. mm/mmap.o is not part of
the nommu build apparently.

So either we move it back to mman.h or put it somewhere else. I do not
have a good idea where, though.

I have dropped mm-factor-commit-limit-calculation-fix from mm-git tree
for now.
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/