Re: [PATCHv3 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq

[Tomasz Figa]

Hi Chanwoo,

Please add a patch description. Even if trivial, it is good to have one.

On Monday 04 of November 2013 10:55:59 Chanwoo Choi wrote:
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos4212.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 6f34d7f..3081bae 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -56,4 +56,10 @@
>  					<0x5 0 &gic 1 12 0>;
>  		};
>  	};
> +
> +	pmu {
> +		compatible = "arm,cortex-a9-pmu";
> +		interrupt-parent = <&combiner>;
> +		interrupts = <2 2>, <3 2>;
> +	};

I believe it would be better to put this in exynos4x12.dtsi, specifying
all four interrupts for possible four cores in Exynos4412. It would be
fine, since the interrupt layout is the same on all Exynos4x12 SoCs, just
some interrupts are not used.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/