Re: [tip:perf/core] tools/perf: Add required memory barriers

From: Ingo Molnar
Date: Mon Nov 11 2013 - 16:10:20 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Thu, Nov 07, 2013 at 09:21:22AM +0100, Ingo Molnar wrote:
> >
> > * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > > > Requiring the user of a kernel interface to have a deep knowledge of
> > > > optimizing compilers, barriers, and CPU memory models is just asking
> > > > for trouble.
> > >
> > > It shouldn't be all that hard to put this in a (lgpl) library others can
> > > link to -- that way you can build it once (using GCC).
> >
> > I'd suggest to expose it via a new perf syscall, using vsyscall methods to
> > not have to enter the kernel for the pure user-space bits. It should also
> > have a real usecase in tools/perf/ so that it's constantly tested, with
> > matching 'perf test' entries, etc.
>
> Oh man, I've never poked at the entire vsyscall stuff before; let alone
> done it for ARM, ARM64, PPC64 etc..
>
> Keeping it in userspace like we have is so much easier.

... and so much more broken in fantastic ways, right? ;-)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/