Re: [PATCH] power: Replace printks with pr_* routines

[Shuah Khan]

On 11/15/2013 03:10 PM, Greg KH wrote:
> On Fri, Nov 15, 2013 at 01:46:21PM -0800, Joe Perches wrote:
> > On Sat, 2013-11-16 at 06:19 +0900, Greg KH wrote:
> > > On Fri, Nov 15, 2013 at 09:10:06AM -0700, Shuah Khan wrote:
> > > > Replaced printks with pr_* routines. dev_* routines could have been used,
> > > > but chose to use pr_* to avoid breaking scripts that might be relying on
> > > > a specific text.
> > >
> > > I'd really like to switch to dev_* instead, even changing to pr_* should
> > > change the output prefix (if it's set for this file, odds are it isn't
> > > though...)
> >
> > It's not.
> >
> > Something like this?
> >
> > Pass a struct device * through to the PM
> > suspend logging routines.  Use dev_<level>
> > instead of printks.
>
> That looks good to me, Shuah, does it work for you?
>
> greg k-h

Looks good to me. I will update and re-send the patch.

-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/