Re: [PATCH] sysfs: use a separate locking class for open filesdepending on mmap

[Greg Kroah-Hartman]

On Sun, Nov 17, 2013 at 12:29:37PM +0900, Tejun Heo wrote:
> On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote:
> > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote:
> > 
> >  
> >  > +	if (has_mmap)
> >  > +		mutex_init(&of->mutex);
> >  > +	else
> >  > +		mutex_init(&of->mutex);
> > 
> > ummm...
> 
> Supposed to look that way.  It'll give two separate static lock class
> keys to of->mutex.  Yeah, looks weird.  Any better ideas?

Doesn't gcc optimize that away to just one lock class anyway?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/