Re: [PATCH 1/3] mfd: cros ec: spi: Add delay for raising CS

[Mark Rutland]

On Mon, Nov 18, 2013 at 10:30:47AM +0000, Thierry Reding wrote:
> From: Rhyland Klein <rklein@xxxxxxxxxx>
> 
> The EC has specific timing it requires. Add support for an optional delay
> after raising CS to fix timing issues. This is configurable based on
> a DT property "google,cros-ec-spi-msg-delay".
> 
> If this property isn't set, then no delay will be added. However, if set
> it will cause a delay equal to the value passed to it to be inserted at
> the end of a transaction.
> 
> Signed-off-by: Rhyland Klein <rklein@xxxxxxxxxx>
> Reviewed-by: Bernie Thompson <bhthompson@xxxxxxxxxxxx>
> Reviewed-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx>
> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
> Cc: Pawel Moll <pawel.moll@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/cros-ec.txt |  4 +++
>  drivers/mfd/cros_ec_spi.c                         | 30 +++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 5f229c5f6da9..fb3034a87ae0 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -17,6 +17,10 @@ Required properties (SPI):
>  - compatible: "google,cros-ec-spi"
>  - reg: SPI chip select
>  
> +Optional properties (SPI):
> +- google,cros-ec-spi-msg-delay: This property is how long of a delay, in usecs,
> +  to use on the last transfer of a message, to force time between transactions.
> +

Lose the "This property is", that's obvious from the structure of the
document.

It would be nice to have an explanation in the binding document as to
_why_ you might want to do this (e.g. the HW expects the rising edge to
come some number of uS after the data, if it comes too early it
explodes).

Otherwise this looks fine to me.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/