Re: [PATCH] Reimplement old functionality of vm_munmap tovm_munmap_mm

[Al Viro]

On Tue, Nov 19, 2013 at 10:29:52AM -0600, James Custer wrote:
> Commit bfce281c287a427d0841fadf5d59242757b4e620 killed the mm parameter to
> vm_munmap. Although the mm parameter was not used in any in-tree kernel
> modules, it is used by some out-of-tree modules.
> 
> We create a new function vm_munmap_mm that has the same functionality as
> vm_munmap, whereas vm_munmap uses current->mm, vm_munmap_mm takes the mm as
> a paramter.
> 
> Since this is a newly exported symbol it is marked EXPORT_SYMBOL_GPL.

Which modules and what are they doing with it?  More to the point,
what prevents races with e.g. dumping core?  And that's not an idle
question - for example, fs/aio.c used to contain very unpleasant
races of that kind exactly because it was playing games with modifying
->mm other than current->mm.

In other words, NAK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/