Re: [GIT PULL] core kernel update

[Linus Torvalds]

On Tue, Nov 19, 2013 at 7:42 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> Josh Boyer (1):
>       smp/cpumask: Make CONFIG_CPUMASK_OFFSTACK=y usable without debug dependency

This seems to be just pure stupid.

Why the hell should we ever ask the user whethr they want to force
CPUMASK offstack?

Seriously, it only leaves room for mistakes and stupidities. There is
no reason for any normal use-case to ask the user about this. Even the
help message is pure and utter garbage ("This is a bit more expensive,
but avoids stack overflow").

The fact is, an on-stack CPUMASK is *smaller* than a pointer to an
offstack one when NR_CPU is small. The question makes no sense then.
And when NR_CPU is huge, the question makes no sense _either_, since
we can't have the cpumasks on stack.

Asking the user questions that make no f*cking sense to ask is stupid.
And I'm not knowingly pulling stupid crap.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/