Re: linux-next: Tree for Nov 15 (target_core_mod)

From: Nicholas A. Bellinger
Date: Tue Nov 19 2013 - 18:12:57 EST


On Tue, 2013-11-19 at 10:08 -0800, Randy Dunlap wrote:
> On 11/18/13 11:46, Nicholas A. Bellinger wrote:

<SNIP>

>
> That does fix the build errors. Thanks.
>
> Here is a more complete patch with a patch description and S-O-B.
> I would have put your S-O-B in it but you didn't include one.
> Feel free to add yours now.
>
> ---
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Drop percpu_ida.o from lib-y since it is also listed in obj-y
> and it doesn't need to be listed in both places.
>
> Move percpu-refcount.o from lib-y to obj-y to fix build errors
> in target_core_mod:
>
> ERROR: "percpu_ref_cancel_init" [drivers/target/target_core_mod.ko] undefined!
> ERROR: "percpu_ref_kill_and_confirm" [drivers/target/target_core_mod.ko] undefined!
> ERROR: "percpu_ref_init" [drivers/target/target_core_mod.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Hi Randy,

Applied.

Thanks!

--nab

> ---
> lib/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20131115.orig/lib/Makefile
> +++ linux-next-20131115/lib/Makefile
> @@ -13,7 +13,7 @@ lib-y := ctype.o string.o vsprintf.o cmd
> sha1.o md5.o irq_regs.o reciprocal_div.o argv_split.o \
> proportions.o flex_proportions.o prio_heap.o ratelimit.o show_mem.o \
> is_single_threaded.o plist.o decompress.o kobject_uevent.o \
> - earlycpio.o percpu-refcount.o percpu_ida.o
> + earlycpio.o
>
> obj-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
> lib-$(CONFIG_MMU) += ioremap.o
> @@ -26,7 +26,7 @@ obj-y += bcd.o div64.o sort.o parser.o h
> bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
> gcd.o lcm.o list_sort.o uuid.o flex_array.o iovec.o clz_ctz.o \
> bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \
> - percpu_ida.o
> + percpu-refcount.o percpu_ida.o
> obj-y += string_helpers.o
> obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
> obj-y += kstrtox.o
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/