Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()

[walter harms]

Am 21.11.2013 20:12, schrieb Andreas Platschek:
> Use tty_write_lock()/tty_write_unlock() consistently.
> 
> This takes care of the following sparse warning:
> drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
> 
> Signed-off-by: Andreas Platschek <andi.platschek@xxxxxxxxx>
> ---
>  drivers/tty/tty_io.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index 3a1a01a..13dca92 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -1165,7 +1165,7 @@ out:
>  void tty_write_message(struct tty_struct *tty, char *msg)
>  {
>  	if (tty) {
> -		mutex_lock(&tty->atomic_write_lock);
> +		tty_write_lock(tty,0);
>  		tty_lock(tty);
>  		if (tty->ops->write && !test_bit(TTY_CLOSING, &tty->flags)) {
>  			tty_unlock(tty);

i am not an expert on this but you may need to replace that tty_unlock() with tty_write_unlock().

re,
 wh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/