Re: [PATCH] mm/zswap: change params from hidden to ro

[Dan Streetman]

On Fri, Nov 22, 2013 at 2:38 AM, Vladimir Murzin <murzin.v@xxxxxxxxx> wrote:
> On Wed, Nov 20, 2013 at 12:52:47PM -0500, Dan Streetman wrote: > On Wed, Nov
> 20, 2013 at 12:33 PM, Vladimir Murzin <murzin.v@xxxxxxxxx> wrote: > > Hi Dan!
>> >
>> > On Wed, Nov 20, 2013 at 11:38:42AM -0500, Dan Streetman wrote:
>> >> The "compressor" and "enabled" params are currently hidden,
>> >> this changes them to read-only, so userspace can tell if
>> >> zswap is enabled or not and see what compressor is in use.
>> >
>> > Could you elaborate more why this pice of information is necessary for
>> > userspace?
>>
>> For anyone interested in zswap, it's handy to be able to tell if it's
>> enabled or not ;-)  Technically people can check to see if the zswap
>> debug files are in /sys/kernel/debug/zswap, but I think the actual
>> "enabled" param is more obvious.  And the compressor param is really
>> the only way anyone from userspace can see what compressor's being
>> used; that's helpful to know for anyone that might want to be using a
>> non-default compressor.
>
> So, it is needed for user not userspace? I tend to think that users are smart
> enough to check cmdline for that.

Let's try a different way.  Can you explain what the problem is with
making these params user-readable?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/