Re: [PATCH 3.2 63/87] ext4: fix memory leak in xattr

From: Dave Jones
Date: Mon Nov 25 2013 - 14:03:23 EST


On Mon, Nov 25, 2013 at 01:44:29PM +0000, Ben Hutchings wrote:
> 3.2.53-rc1 review patch. If anyone has any objections, please let me know.
>
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1269,6 +1269,8 @@ retry:
> s_min_extra_isize) {
> tried_min_extra_isize++;
> new_extra_isize = s_min_extra_isize;
> + kfree(is); is = NULL;
> + kfree(bs); bs = NULL;
> goto retry;
> }
> error = -1;

There was a follow-on patch that frees the bh too.

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/