Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1]ARM related to STS flag

[Chris Ruehl]

On Saturday, November 30, 2013 06:20 PM, Peter Chen wrote:
> > usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
> >
> > * init the sts flag to 0 (missed)
> > * Set PORTCS_STS only if VUSB_HS_PHY_TYPE>  1
> >    otherwise the register is ReadOnly
> > * Set/Reset correct BIT(28)/BIT(29) for STS
> >
> > Signed-off-by: Chris Ruehl<chris.ruehl@xxxxxxxxxxxx>
> > ---
> >   drivers/usb/chipidea/core.c |   20 +++++++++++++++++---
> >   1 file changed, 17 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> > index 5075407..2c634c1 100644
> > --- a/drivers/usb/chipidea/core.c
> > +++ b/drivers/usb/chipidea/core.c
> > @@ -243,7 +243,7 @@ static int hw_device_init(struct ci_hdrc *ci, void
> > __iomem *base)
> >
> >   static void hw_phymode_configure(struct ci_hdrc *ci)
> >   {
> > -	u32 portsc, lpm, sts;
> > +	u32 portsc, lpm, sts = 0;
> >
> >   	switch (ci->platdata->phy_mode) {
> >   	case USBPHY_INTERFACE_MODE_UTMI:
> > @@ -273,10 +273,24 @@ static void hw_phymode_configure(struct ci_hdrc *ci)
> >
> >   	if (ci->hw_bank.lpm) {
> >   		hw_write(ci, OP_DEVLC, DEVLC_PTS(7) | DEVLC_PTW, lpm);
> > -		hw_write(ci, OP_DEVLC, DEVLC_STS, sts);
> > +		if ( sts )
> > +			hw_write(ci, OP_DEVLC, DEVLC_STS, BIT(28));
> > +		else
> > +			hw_write(ci, OP_DEVLC, DEVLC_STS, ~BIT(28));
> >   	} else {
> >   		hw_write(ci, OP_PORTSC, PORTSC_PTS(7) | PORTSC_PTW, portsc);
> > -		hw_write(ci, OP_PORTSC, PORTSC_STS, sts);
> > +		if (((portsc>>  30)&  0x3)>  1) {
> > +			if (sts) {
> > +				hw_write(ci, OP_PORTSC, PORTSC_STS, BIT(29));
> > +			}
> > +			else {
> > +				portsc = (ioread32(ci->hw_bank.regmap[OP_PORTSC])
> > +						&  PORTSC_STS);
> > +				if (portsc)
> > +					hw_write(ci, OP_PORTSC, PORTSC_STS,
> > +							~BIT(29));
> > +			}
> > +		}
> >   	}
> >   }
> >
> > --
>
> At my chipidea datasheet, the VUSB_HS_PHY_SERIAL is at HWGENERAL (bit[10..11]),
> We are still not sure the portsc_sts is needed to set or clear, and how to do
> it. My suggestion is just use v2 patch (except fixing one code style problem)
>
> Peter

Peter,
Thanks you for your comments.

If you have a look into the function hw_write() you will see that there is no 
effect if hw_write(...,sts) is called with sts=0/1, because the mask will cut 
off all bits beside BIT(29).
I used BIT(29) rather then PORTCS_STS to make it more clear what going on.
A write to PORTCS will always be "0" for the STS Register no matter if sts is 1 
or 0 within Patch v2. Patch v3 will take care of the registers bit position and 
set 1 or 0 to PORTCS_STS.

I used the imx27 reference manual Capital 30.8.1.5.12 PORTSCx.

Please comment.
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/