Re: [PATCH 03/17] tracing/kprobes: Factor out struct trace_probe

[Namhyung Kim]

Hi Srikar,

On Fri, 29 Nov 2013 14:55:21 +0530, Srikar Dronamraju wrote:
> * Namhyung Kim <namhyung@xxxxxxxxxx> [2013-11-27 15:19:49]:
>>  /**
>>   * Kprobe event core functions
>>   */
>> -struct trace_probe {
>> +struct trace_kprobe {
>>  	struct list_head	list;
>>  	struct kretprobe	rp;	/* Use rp.kp for kprobe use */
>>  	unsigned long 		nhit;
>> -	unsigned int		flags;	/* For TP_FLAG_* */
>>  	const char		*symbol;	/* symbol name */
>> -	struct ftrace_event_class	class;
>> -	struct ftrace_event_call	call;
>> -	struct list_head	files;
>> -	ssize_t			size;		/* trace entry size */
>> -	unsigned int		nr_args;
>> -	struct probe_arg	args[];
>> +	struct trace_probe	p;
>
> Can I suggest to use tp instead of p to denote trace_probe?

Sure.  I'll change it.

>
>>  };
>> 
>> 
>
> <..snipped..>
>
>> -static int register_probe_event(struct trace_probe *tp);
>> -static int unregister_probe_event(struct trace_probe *tp);
>> +static int register_kprobe_event(struct trace_kprobe *tk);
>> +static int unregister_kprobe_event(struct trace_kprobe *tk);
>> 
>>  static DEFINE_MUTEX(probe_lock);
>>  static LIST_HEAD(probe_list);
>> @@ -107,14 +91,14 @@ static int kretprobe_dispatcher(struct kretprobe_instance *ri,
>>  /*
>>   * Allocate new trace_probe and initialize it (including kprobes).
>>   */
>> -static struct trace_probe *alloc_trace_probe(const char *group,
>> +static struct trace_kprobe *alloc_trace_kprobe(const char *group,
>>  					     const char *event,
>>  					     void *addr,
>>  					     const char *symbol,
>>  					     unsigned long offs,
>>  					     int nargs, bool is_return)
>>  {
>> -	struct trace_probe *tp;
>> +	struct trace_kprobe *tp;
>
> Nit: Here and couple of places below: Given that tk was used to
> represent trace_kprobe, can we use tk everywhere. Using tp to represent
> trace_probe and trace_kprobe is a bit confusing.

Right.  I did it because changing it to 'tk' leads to many oneline hunks
here and there so I worried it might disturb reviewers.

But yeah, I also dislike it.  I'll change it to have consistent names.

>
>>  	int ret = -ENOMEM;
>> 
>
> The rest looks fine.

Thanks for your review!
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/