Re: [f2fs-dev] [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file()failed

[Younger Liu]

On 2013/12/3 13:49, Chao Yu wrote:
> Hi Liu,
>
> You're right, we should release it instead of holding the resource
> with no use. And here are some comments as following.
>
> BTW, your patch is out of format. You'd better not let remote
> terminal or editor to instead tab with blanks in the patch.
>
> Thanks,
> Yu
  Hi Yu,
  thanks for your review. I will modify the patch
and resent in a moment.
>> -----Original Message-----
>> From: Younger Liu [mailto:younger.liucn@xxxxxxxxx]
>> Sent: Monday, December 02, 2013 9:16 PM
>> To: Jaegeuk Kim
>> Cc: fs-devel; kernel; f2fs
>> Subject: [f2fs-dev] [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed
>>
>> From: Younger Liu <liuyiyang@xxxxxxxxxxx>
>>
>> When debugfs_create_file() failed in f2fs_create_root_stats(),
>> debugfs_root should be removed.
>>
>> Signed-off-by: Younger Liu <liuyiyang@xxxxxxxxxxx>
>> Cc: Younger Liu <younger.liucn@xxxxxxxxx>
>> Cc: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>
>> ---
>>  fs/f2fs/debug.c |   20 +++++++++++++++++---
>>  1 file changed, 17 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
>> index a84b0a8..d27b689 100644
>> --- a/fs/f2fs/debug.c
>> +++ b/fs/f2fs/debug.c
>> @@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi)
>>
>>  void __init f2fs_create_root_stats(void)
>>  {
>> +    struct dentry *file;
>> +
>>      debugfs_root = debugfs_create_dir("f2fs", NULL);
>> -    if (debugfs_root)
>> -        debugfs_create_file("status", S_IRUGO, debugfs_root,
>> -                     NULL, &stat_fops);
>> +    if (!debugfs_root)
>> +        goto bail;
>> +
>> +    file = debugfs_create_file("status", S_IRUGO,
>> +            debugfs_root, NULL, &stat_fops);
>> +    if (!file)
>> +        goto free_debugfs_dir;
>> +
>> +    return;
>> +
>> +free_debugfs_dir:
>> +    debugfs_remove(debugfs_root);
> debugfs_root = NULL;
>
>> +
>> +bail:
>> +    return;
>>  }
>>
>>  void f2fs_destroy_root_stats(void)
> You should judge debugfs_root value in f2fs_destroy_root_stats
> to decide free or not.
>
>> --
>> 1.7.9.5
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Rapidly troubleshoot problems before they affect your business. Most IT
>> organizations don't have a clear picture of how application performance
>> affects their revenue. With AppDynamics, you get 100% visibility into your
>> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
>> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT 
> organizations don't have a clear picture of how application performance 
> affects their revenue. With AppDynamics, you get 100% visibility into your 
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/