Re: sysfs: use a separate locking class for open files depending onmmap

[Tejun Heo]

Hello, Dave.

On Tue, Dec 03, 2013 at 01:43:24PM -0500, Dave Jones wrote:
>  > +	/*
>  > +	 * The following is done to give a different lockdep key to
>  > +	 * @of->mutex for files which implement mmap.  This is a rather
>  > +	 * crude way to avoid false positive lockdep warning around
>  > +	 * mm->mmap_sem - mmap nests @of->mutex under mm->mmap_sem and
>  > +	 * reading /sys/block/sda/trace/act_mask grabs sr_mutex, under
>  > +	 * which mm->mmap_sem nests, while holding @of->mutex.  As each
>  > +	 * open file has a separate mutex, it's okay as long as those don't
>  > +	 * happen on the same file.  At this point, we can't easily give
>  > +	 * each file a separate locking class.  Let's differentiate on
>  > +	 * whether the file has mmap or not for now.
>  > +	 */
>  > +	if (has_mmap)
>  > +		mutex_init(&of->mutex);
>  > +	else
>  > +		mutex_init(&of->mutex);
>  > +
>  
> Somehow I just triggered this trace again, even with this commit applied.
> The trace is pretty much identical to the old one.

Hah, ain't that weird.  That's the trace you reported on the other
mail, right?  I'll follow up on that one.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/