Re: [PATCH v3 3/4] pwm: add LP3943 PWM driver

[Milo Kim]

Hi Thierry,

On 12/03/2013 07:24 PM, Thierry Reding wrote:
> On Thu, Sep 12, 2013 at 10:33:50AM +0900, Milo Kim wrote:
> > This is the other of the LP3943 MFD driver.
> > LP3943 can be used as a PWM generator, up to 2 channels.
> >
> > * Two PWM generators supported
> >
> > * Supported PWM operations
> >    request, free, config, enable and disable
> >
> > * Pin assignment
> >    A driver data, 'pin_used' is checked when a PWM is requested.
> >    If the output pin is already assigned, then returns as failure.
> >    If the pin is available, 'pin_used' is set.
> >    When the PWM is not used anymore, then it is cleared.
> >    It is defined as unsigned long type for atomic bit operation APIs,
> >    but only LSB 16bits are used because LP3943 has 16 outputs.
> >
> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Signed-off-by: Milo Kim <milo.kim@xxxxxx>
> > ---
> > * Patch v3
> >    Manual polarity not supported any more.
> >    Add encapsulation functions for accessing internal data structure.
> >    Use pwm_set_chip_data() and pwm_get_chip_data().
> >    And other code fixes based on Thierry's feedback.
> >
> >   drivers/pwm/Kconfig      |   10 ++
> >   drivers/pwm/Makefile     |    1 +
> >   drivers/pwm/pwm-lp3943.c |  314 ++++++++++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 325 insertions(+)
> >   create mode 100644 drivers/pwm/pwm-lp3943.c
>
> Hi Milo,
>
> Is this patchset still the latest version? I've tried to remember the
> status of this series, but I could only draw a blank.

Thanks a lot for this reminder.
I forgot to check the status.

The latest one is the v4, but LP3943 PWM driver code is same as v3.

  Update from v3 to v4:
    Move the driver description from the documentation to the MFD 
driver file.

There are two things to be ACKed for v4.
One is the PWM driver. (https://lkml.org/lkml/2013/9/25/11)
The other is the documentation. (https://lkml.org/lkml/2013/9/25/10)

Thanks,
  Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/