Re: [PATCH 22/41] rcu: Replace __this_cpu_ptr uses with raw_cpu_ptr

[Paul E. McKenney]

On Tue, Dec 03, 2013 at 05:32:54PM -0600, Christoph Lameter wrote:
> __this_cpu_ptr is being phased out.
> 
> One special case is increment_cpu_stall_ticks().
> A per cpu variable is incremented so use raw_cpu_inc().
> 
> Cc: Dipankar Sarma <dipankar@xxxxxxxxxx>
> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

This does not build on 3.13-rc2.  Ah, need a couple of patches earlier
in the series.

But...  But...  Didn't we recently change -to- __this_cpu_ptr() from
the older __get_cpu_var()?

							Thanx, Paul

------------------------------------------------------------------------
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c: In function ârcu_adopt_orphan_cbsâ:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:1943:9: error: implicit declaration of function âraw_cpu_ptrâ [-Werror=implicit-function-declaration]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:1943:25: warning: initialization makes pointer from integer without a cast [enabled by default]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c: In function â__rcu_process_callbacksâ:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:2322:25: warning: initialization makes pointer from integer without a cast [enabled by default]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c: In function ârcu_barrier_funcâ:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:2923:25: warning: initialization makes pointer from integer without a cast [enabled by default]
In file included from /media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:3467:0:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h: In function ârcu_oom_notify_cpuâ:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h:1846:7: warning: assignment makes pointer from integer without a cast [enabled by default]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h: In function âincrement_cpu_stall_ticksâ:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h:1988:3: error: implicit declaration of function âraw_cpu_incâ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [kernel/rcu/tree.o] Error 1
make[1]: *** [kernel/rcu/tree.o] Error 2
make: *** [sub-make] Error 2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/