RE: [f2fs-dev] [PATCH v2] f2fs: refactor bio-related operations

[Chao Yu]

Hi,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk.kim@xxxxxxxxxxx]
> Sent: Wednesday, December 04, 2013 4:11 PM
> To: Chao Yu
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx; èå
> Subject: RE: [f2fs-dev] [PATCH v2] f2fs: refactor bio-related operations
> 
> Hi,
> 
> > > +	if (btype == META)
> > > +		rw |= REQ_META;
> > > +
> > > +	if (is_read_io(rw)) {
> > > +		if (sync)
> > > +			rw |= READ_SYNC;
> > > +		submit_bio(rw, io->bio);
> > > +		trace_f2fs_submit_read_bio(sbi->sb, rw, type, io->bio);
> > > +		io->bio = NULL;
> > > +		return;
> > > +	}
> > > +
> > > +	if (sync)
> > > +		rw |= WRITE_SYNC;
> >
> > rw = WRITE_SYNC; ?
> 
> No, since it removes the REQ_META.
> See above.

Ah, you're right, Thanks.

> 
> >
> > > +	if (type >= META_FLUSH)
> > > +		rw |= WRITE_FLUSH_FUA;
> >
> > rw = WRITE_FLUSH_FUA; ?
> >
> > > +
> > > +	/*
> > > +	 * META_FLUSH is only from the checkpoint procedure, and we should wait
> > > +	 * this metadata bio for FS consistency.
> > > +	 */
> > > +	if (type == META_FLUSH) {
> > > +		DECLARE_COMPLETION_ONSTACK(wait);
> > > +		io->bio->bi_private = &wait;
> > > +		submit_bio(rw, io->bio);
> > > +		wait_for_completion(&wait);
> > > +	} else {
> > > +		submit_bio(rw, io->bio);
> > > +	}
> > > +	trace_f2fs_submit_write_bio(sbi->sb, rw, btype, io->bio);
> > > +	io->bio = NULL;
> > > +}
> >
> > [snip]
> >
> > Thanks,
> > Yu
> >
> 
> --
> Jaegeuk Kim
> Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/