Re: [PATCH v4 3/4] pwm: add LP3943 PWM driver

[Thierry Reding]

On Wed, Sep 25, 2013 at 01:24:38PM +0900, Milo Kim wrote:
> This is the other of the LP3943 MFD driver.
> LP3943 can be used as a PWM generator, up to 2 channels.
> 
> * Two PWM generators supported
> 
> * Supported PWM operations
>   request, free, config, enable and disable
> 
> * Pin assignment
>   A driver data, 'pin_used' is checked when a PWM is requested.
>   If the output pin is already assigned, then returns as failure.
>   If the pin is available, 'pin_used' is set.
>   When the PWM is not used anymore, then it is cleared.
>   It is defined as unsigned long type for atomic bit operation APIs,
>   but only LSB 16bits are used because LP3943 has 16 outputs.
> 
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Signed-off-by: Milo Kim <milo.kim@xxxxxx>
> ---
> * Patch v4
>   No update, same as v3.
> 
> * Patch v3
>   Manual polarity not supported any more.
>   Add encapsulation functions for accessing internal data structure.
>   Use pwm_set_chip_data() and pwm_get_chip_data().
>   And other code fixes based on Thierry's feedback.
> 
>  drivers/pwm/Kconfig      |   10 ++
>  drivers/pwm/Makefile     |    1 +
>  drivers/pwm/pwm-lp3943.c |  314 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 325 insertions(+)
>  create mode 100644 drivers/pwm/pwm-lp3943.c

Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx>

Attachment: pgp00000.pgp
Description: PGP signature