Re: [RFC part1 PATCH 3/7] ACPI / processor_core: Rework _PDC relatedstuff to make it more arch-independent

[Hanjun Guo]

On 2013å12æ04æ 00:46, Matthew Garrett wrote:
> On Wed, Dec 04, 2013 at 12:36:47AM +0800, Hanjun Guo wrote:
>
> > +#if defined(CONFIG_X86) || defined(CONFIG_IA64)
> >   	/* Enable coordination with firmware's _TSD info */
> >   	buf[2] = ACPI_PDC_SMP_T_SWCOORD;
> > +	if (boot_option_idle_override == IDLE_NOMWAIT) {
> > +		/*
> > +		 * If mwait is disabled for CPU C-states, the C2C3_FFH access
> > +		 * mode will be disabled in the parameter of _PDC object.
> > +		 * Of course C1_FFH access mode will also be disabled.
> > +		 */
> > +		buf[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);
> > +
> > +	}
> > +#endif
> This is (fairly) arch-specific, so why not move it to
> arch_acpi_set_pdc_bits()?

Ok, it will make the code much cleaner, will update in next version.

Thanks
Hanjun


>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/